On Wed, Aug 22, 2012 at 3:55 PM, Stefan Fritsch <s...@sfritsch.de> wrote: > Here is the current version. Changes from v6: > > - net: rename device vioif -> vio > - net: don't use watchdog for cleaning up tx descriptors > (in fact, remove watchdog completely) > - net: various fixes for RingEventIdx mode; should fix johnw's hang > - net: fix panic if ctrl ring was in use during device reset > - some coding style cleanup > - some fixes in error handling > > Cheers, > Stefan >
could you please rename vio_tx_load to vio_encap in your next revision. vio_deferred_init should be called vio_attachhook really. also vio_txtick might be a better name for vio_timeout. also, you've forgotten splnet's in there. if you'd look at other network drivers, you'd notice that mac address printf says "address": em0 at pci0 dev 25 function 0 "Intel 82578DM" rev 0x06: msi, address 00:21:86:fa:5f:c1 cheers
