On Fri, Jul 13, 2012 at 04:07:20PM +0200, Yasuoka Masahiko wrote: > npppd used wrong AVPs as a `calling number' because `break' in switch > case was missing. > > ok? >
OK. > Index: npppd/l2tp/l2tp_call.c > =================================================================== > RCS file: /cvs/src/usr.sbin/npppd/l2tp/l2tp_call.c,v > retrieving revision 1.12 > diff -u -p -r1.12 l2tp_call.c > --- npppd/l2tp/l2tp_call.c 8 May 2012 13:18:37 -0000 1.12 > +++ npppd/l2tp/l2tp_call.c 13 Jul 2012 13:59:05 -0000 > @@ -329,6 +329,7 @@ l2tp_call_recv_ICRQ(l2tp_call *_this, u_ > * Windows 98/Me/NT asserts mandatory bit in > * Physical Channel Id > */ > + break; > case L2TP_AVP_TYPE_CALLING_NUMBER: > slen = MIN(sizeof(_this->calling_number) - 1, > avp_attr_length(avp)); -- :wq Claudio
