* sven falempin <sven.falem...@gmail.com> [2012-07-12 17:37]:
> Inline diff

even without judging on wether we'll want that at all (I'm still
sceptic):

> +//inline
> +int
> +bridge_test_ea(struct ether_addr *ea_packet, struct ether_addr *ea_rules,
> +    struct ether_addr *ea_mask) {
> + int i;
> + struct ether_addr ea_cmp;
> + for (i = 0; i < ETHER_ADDR_LEN; ++i) {
> + ea_cmp.ether_addr_octet[i] = ea_mask->ether_addr_octet[i]
> + & ea_packet->ether_addr_octet[i];
> + }
> + return (bcmp(&ea_cmp, ea_rules, ETHER_ADDR_LEN));
> +}
> +

that is horribly ugly. spend some time with style(9).

-- 
Henning Brauer, h...@bsws.de, henn...@openbsd.org
BS Web Services, http://bsws.de, Full-Service ISP
Secure Hosting, Mail and DNS Services. Dedicated Servers, Root to Fully Managed
Henning Brauer Consulting, http://henningbrauer.com/

Reply via email to