Having muttered a bunch, I'm in favor of this.  One last comment:

On Wed, Aug 31, 2011 at 2:17 AM, Uwe Stuehler <u...@openbsd.org> wrote:
> --- bin/ps/ps.1 6 Jul 2011 21:42:11 -0000       1.76
> +++ bin/ps/ps.1 31 Aug 2011 09:01:06 -0000
...
> +.It Fl H
> +Also display information about kernel visible process threads.
> +This flag only applies when the
> +.Sq kern.rthreads
> +sysctl variable is non-zero and there are processes that use kernel
> +threading.

I think the second sentence there should be left out.  The flag always
applies: you just won't see any difference if you don't have any
kernel visible threads.  ps(1) isn't the place for how to create
different types of threads, IMO.

And yes, I think "kernel visible process threads" should be just
"kernel visible threads".


If there are no objections, I'll commit this with the ps.1 diff reduced to:

--- ps.1        6 Jul 2011 21:42:11 -0000       1.76
+++ ps.1        18 Sep 2011 23:27:44 -0000
@@ -39,7 +39,7 @@
 .Sh SYNOPSIS
 .Nm ps
 .Sm off
-.Op Fl aCcehjkLlmrSTuvwx
+.Op Fl aCceHhjkLlmrSTuvwx
 .Sm on
 .Op Fl M Ar core
 .Op Fl N Ar system
@@ -89,6 +89,8 @@ scripts will show as
 .Dq sh .
 .It Fl e
 Display the environment as well.
+.It Fl H
+Also display information about kernel visible threads.
 .It Fl h
 Repeat the information header as often as necessary to guarantee one
 header per page of information.


Philip Guenther

Reply via email to