On Fri, Jul 22, 2011 at 09:46:45AM -0400, Kenneth R Westerback wrote: > On Fri, Jul 22, 2011 at 02:51:32PM +0200, Martin Pelikan wrote: > > The whole logic in these two seems pretty ugly, but inet6 crashed when I > > tried to make it look prettier and more uniform. > > What is the point of the #define? If anything I'd go the other way > and move the refcount check into ifafree(). Saving a function call > at the expense of bloating the kernel has, in other cases, been > shown to be a losing proposition. I can only see fewer than 30
Like I said, I tried to make it look better and the netinet6 part of the tree crashed in places I'm not familiar with. So I backed off and after reading the 5.0 announcement posted it here to further discussion. Or, we can introduce ifa_free() which would look and function correct, and migrate all IFAFREE() and ifafree() calls towards that, one by one. If you believe this is the time for such changes, tell me and I'll keep hacking/testing. In such case, when no new users of ifafree are added, the panic can safely go away. -- Martin Pelikan
