Hi,

sorry for sending this after the 5.0-beta announcement, too much work.

I don't know why does vether(4) need the 'media' option, but if you
create and destroy lots of vethers, M_IFADDRs are leaking.  This idea is
taken from trunk(4).

There is still another one malloc() leaking, though.
--
Martin Pelikan


Index: net/if_vether.c
===================================================================
RCS file: /cvs/src/sys/net/if_vether.c,v
retrieving revision 1.15
diff -u -p -r1.15 if_vether.c
--- net/if_vether.c     2 Apr 2010 21:45:49 -0000       1.15
+++ net/if_vether.c     22 Jul 2011 11:24:41 -0000
@@ -106,6 +106,7 @@ vether_clone_destroy(struct ifnet *ifp)
 {
        struct vether_softc     *sc = ifp->if_softc;
 
+       ifmedia_delete_instance(&sc->sc_media, IFM_INST_ANY);
        ether_ifdetach(ifp);
        if_detach(ifp);
        free(sc, M_DEVBUF);

Reply via email to