On Mon, May 09, 2011 at 11:29:14PM +0200, Matthieu Herrb wrote:
> On Mon, May 09, 2011 at 04:14:32PM -0400, Brynet wrote:
> > I noticed the following in my Xorg.0.log:
> >
> > Touchpad0: invalid pressure range. defaulting to 0 - 256
> > Touchpad0: invalid finger width range. defaulting to 0 - 16
> >
> > Just curious if that's normal.
>
> More or less. The test and the error message are lame, to say that the
> hw specific layer (wsconscomm.c) didn't set the values.
>
> Alexandr, I wonder if it's possible to get these filled from the pms
> driver (it probably means adding more ioctls :()
> --
> Matthieu Herrb
The ranges for pressure and width specified in datasheet.
I do not see a need for new ioctls. I think is better to explicitly
define minp, maxp (etc.) in wsconscomm.c. This will remove confusing
messages.
--
Alexandr Shadchin
Index: wsconscomm.c
===================================================================
RCS file: /cvs/xenocara/driver/xf86-input-synaptics/src/wsconscomm.c,v
retrieving revision 1.2
diff -u -p -r1.2 wsconscomm.c
--- wsconscomm.c 7 May 2011 17:30:31 -0000 1.2
+++ wsconscomm.c 10 May 2011 07:09:20 -0000
@@ -243,6 +243,12 @@ WSConsReadDevDimensions(InputInfoPtr pIn
xf86Msg(X_PROBED, "%s: y-axis range %d - %d resolution %d\n",
pInfo->name, priv->miny, priv->maxy, priv->resy);
+ priv->minp = 0;
+ priv->maxp = 256;
+
+ priv->minw = 0;
+ priv->maxw = 16;
+
priv->has_pressure = TRUE;
priv->has_width = TRUE;
priv->has_left = TRUE;
