As expressed privately the diff reads fine to me and I like the idea,
it compiles and runs, tentative ok pyr@ for now, but let's wait for
some usage feedback a bit later this week.
On Fri, May 6, 2011 at 9:16 PM, Reyk Floeter <r...@openbsd.org> wrote:
> On Fri, May 06, 2011 at 08:12:43PM +0200, Reyk Floeter wrote:
>> hi,
>>
>> the following diff needs some serious testing in existing setups.
>> it does not add any new features...
>>
>> ...but it reorganizes, shuffles, and changes the relayd code and
>> internal APIs and it introduces an privsep API that is based on iked
>> and smtpd. why? before i continue working on relayd, i need to sync
>> it to 2011 and clean it up a bit. i also intend to sync the changes
>> in proc.c back to iked. more cleanup and infrastructure changes will
>> follow later and i intend to work on some outstanding issues in
>> relayd. for example, proper reload support will need a rewrite of the
>> existing reload code and even a redesign of some relayd
>> infrastructure... this is the first step.
>>
>> so my main interest is if this diff breaks anything otherwise i will
>> go ahead and commit it after a while.
>>
>> any testers?
>>
>
> i missed the relayctl bit in the previous diff.
>
> Index: usr.sbin/relayctl/relayctl.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/relayctl/relayctl.c,v
> retrieving revision 1.42
> diff -u -p -r1.42 relayctl.c
> --- usr.sbin/relayctl/relayctl.c 31 Dec 2010 21:22:42 -0000
1.42
> +++ usr.sbin/relayctl/relayctl.c 6 May 2011 19:13:23 -0000
> @@ -189,7 +189,7 @@ main(int argc, char *argv[])
> verbose = 2;
> /* FALLTHROUGH */
> case LOG_BRIEF:
> - imsg_compose(ibuf, IMSG_CTL_LOG_VERBOSE, 0, 0, -1,
> + imsg_compose(ibuf, IMSG_CTL_VERBOSE, 0, 0, -1,
> &verbose, sizeof(verbose));
> printf("logging request sent.\n");
> done = 1;
> return;
