I agree. In fact attaching those devices on the 620 makes no sense. On Apr 1, 2011, at 17:20, Martynas Venckus <marty...@venck.us> wrote:
> On 4/2/11, Paul Irofti <p...@irofti.net> wrote: >> What about devices that should support _DOS and don't support >> brightness? I've tested this on a D620 (which has the methods but does >> brightness through the BIOS) and the relevant dmesg diff is: >> >> -acpivout0 at acpivideo1: TV__ >> -acpivout1 at acpivideo1: CRT_ >> -acpivout2 at acpivideo1: LCD_ >> -acpivout3 at acpivideo1: DVI_ >> >> This makes sense I guess because they're useless on this model, but I'm >> not sure about other laptops. > > The first revision of the diff I've posted to you (offlist) handles > this, i.e. attaches to all _DOD, and then additionally to all devices > having the brightness methods. > > But I don't see a need for complexity in this case--if device doesn't > have the relevant methods, acpivoutX would attach doing nothing (like > in your case). This way is both simpler and more reliable.
