On Thu, Mar 10, 2011 at 11:20:57PM +0000, Stuart Henderson wrote:
> On 2011/03/10 14:48, Mike Larkin wrote:
> > This diff adds support to puc(4) for NetMos 9922 dual serial
> > cards. It's pretty straightforward. Tested by me on i386 and
> > amd64.
> 
> > +   /* NetMos PCIe Peripheral Controller :Dual serial port */
> 
> the usual style in this file is like /* Blah blah: 2S */

ok.

> 
> > +   {   /* "NetMos NM9922 2xUART" */
> > +       {   PCI_VENDOR_NETMOS, PCI_PRODUCT_NETMOS_NM9922, 0x0, 0x0 },
> > +       {   0xffff, 0xffff,                               0x0, 0x0 },
> > +       {
> > +           { PUC_PORT_TYPE_COM, 0x10, 0x00, COM_FREQ },
> > +       },
> > +   },
> 
> this is just one of the two ports isn't it?
> 

It's multifunction and appears as 2 PCI devices with the same IDs,
so only this one definition is needed.

-ml

Reply via email to