On Tue, Feb 15, 2011 at 01:28:28PM +0000, Stuart Henderson wrote: > On 2011/02/15 14:05, Claudio Jeker wrote: > > > > > > /* > > > * Micro Linear PHY reports oui == 0 model == 0 > > > */ > > > if (MII_OUI(ma->mii_id1, ma->mii_id2) != 0 || > > > MII_MODEL(ma->mii_id2) != 0) > > > return (0); > > > /* > > > * Make sure the parent is a `tl'. So far, I have only > > > * encountered the 6692 on an Olicom card with a ThunderLAN > > > * controller chip. > > > */ > > > if (strcmp(parent->dv_cfdata->cf_driver->cd_name, "tl") != 0) > > > return (0); > > > > I don't like this. Why restrict it to tl(4) only. The phy may work on any > > other mii bus so there is no reason for this restriction. > > I'm not sure attaching to every OUI 0x000000 model 0x0000 is safe.. > > pcn0 at pci0 dev 3 function 0 "AMD 79c970 PCnet-PCI" rev 0x30, Am79c973, rev > 0: irq 11, address 08:00:27:6a:ef:bc > ukphy0 at pcn0 phy 0: Generic IEEE 802.3u media interface, rev. 0: OUI > 0x000000, model 0x0000 > > mos0 at uhub0 port 4 configuration 1 interface 0 "Moschip Semiconductor > USB-MAC Controller" rev 2.00/1.00 addr 2 > mos0: MCS7830, address 00:0c:f6:3a:f4:46 > ukphy0 at mos0 phy 1: Generic IEEE 802.3u media interface, rev. 0: OUI > 0x000000, model 0x0000 >
Hmm. Right. Forgot that the PHY has no oui or model. So ignore that. -- :wq Claudio
