> Date: Thu, 25 Nov 2010 18:04:23 -0500
> From: Kenneth R Westerback <kwesterb...@rogers.com>
> 
> Hmmm. I can't actually find any *use* of cpus_attached. Is it a relic?
> 
> The diff below compiles and runs fine on my 6-proc amd64 box.

Sure, nuke it.

> Index: amd64/cpu.c
> ===================================================================
> RCS file: /cvs/src/sys/arch/amd64/amd64/cpu.c,v
> retrieving revision 1.38
> diff -u -p -r1.38 cpu.c
> --- amd64/cpu.c       13 Nov 2010 04:16:42 -0000      1.38
> +++ amd64/cpu.c       25 Nov 2010 23:00:44 -0000
> @@ -135,8 +135,6 @@ struct cpu_info cpu_info_primary = { 0, 
>  
>  struct cpu_info *cpu_info_list = &cpu_info_primary;
>  
> -u_int32_t cpus_attached = 0;
> -
>  #ifdef MULTIPROCESSOR
>  /*
>   * Array of CPU info structures.  Must be statically-allocated because
> @@ -345,8 +343,6 @@ cpu_attach(struct device *parent, struct
>               panic("unknown processor type??");
>       }
>       cpu_vm_init(ci);
> -
> -     cpus_attached |= (1 << ci->ci_cpuid);
>  
>  #if defined(MULTIPROCESSOR)
>       if (mp_verbose) {
> Index: include/cpu.h
> ===================================================================
> RCS file: /cvs/src/sys/arch/amd64/include/cpu.h,v
> retrieving revision 1.60
> diff -u -p -r1.60 cpu.h
> --- include/cpu.h     22 Nov 2010 21:07:18 -0000      1.60
> +++ include/cpu.h     25 Nov 2010 23:00:44 -0000
> @@ -211,8 +211,6 @@ extern struct cpu_info cpu_info_primary;
>  
>  #define aston(p)     ((p)->p_md.md_astpending = 1)
>  
> -extern u_int32_t cpus_attached;
> -
>  #define curpcb               curcpu()->ci_curpcb
>  
>  /*

Reply via email to