Re: patch to add RequestHeader directive to httpd mod_headers.c

[Alexander Hall]

On 09/12/10 18:20, Sebastian Reitenbach wrote:

> -    table *tbl = (hdr->do_err ? r->err_headers_out : r->headers_out);
> +    table *tbl;
> +    switch (hdr->inout) {
> +    case hdrs_out:
> +      tbl = r->headers_out;
> +      break;
> +    case hdrs_in:
> +      tbl = r->headers_in;
> +      break;
> +    }
> +    tbl = (hdr->do_err ? r->err_headers_out : r->headers_out);

Err... Set tbl above and then set it again?

Also, what's with the indentation?

>          switch (hdr->action) {
>          case hdr_add:
>              ap_table_addn(tbl, hdr->header, hdr->value);