On Tue, 2 Feb 2010 09:10:56 -0500 Okan Demirmen <o...@demirmen.com> wrote:
> On Sun 2010.01.17 at 16:05 +0100, Thomas Pfaff wrote: > > This diff disallows setting blank labels and pressing Esc while editing > > the current one will leave it unchanged. I don't see the point in allowing > > empty labels as the windows will just show up as blank entries in the menu. > > i believe due to the nature of menu_filter(), you'll still run into > losing your label using just strlen(). below the least intrusive way > until we potentially look back at the menu code. > > i don't use labels at all, so can you verify this fixes all your cases? > Thanks, this seem to work just fine and it also allows you to set blank labels. Not being able to do so was just a side effect of my diff. The main motivation for the diff was to have Esc bail out of the editor and not apply any changes. While we're here, I think it'd be very nice if the initial label would be set to that of the window name. E.g. when I start a new xterm it gets the name "xterm" in the menu. When I edit its label, it starts out blank. It should start out as "xterm" in my opinion. I don't have a diff for this one yet, sorry. Cheers, Thomas.
