On Saturday, January 9, 2010, Joerg Sonnenberger <jo...@britannica.bec.de> wrote: > On Sat, Jan 09, 2010 at 08:15:20PM +0000, Grumpy wrote: >> > > @@ -350,7 +359,7 @@ >> > > * referencing buffers. >> > > */ >> > > toggle ^= 1; >> > > - if (numvnodes > 2 * maxvnodes) >> > > + if (numvnodes / 2 > maxvnodes) >> > > toggle = 0; >> > >> > + if ((numvnodes >> 1) > maxvnodes) >> > >> > slightly better? >> >> I find your lack of faith in the compiler disturbing. > > I find your lack of type checking before trolling disturbing.
<stares at the code> Ummm, what? AFAICT, the only difference between the two variants that I can see is that the shift version might behave differently if numvnodes is negative, which can't happen. Can you be less funny and more clear about what type checking issue you see? Philip Guenther
