On Sun, 09 Aug 2009 11:59:03 +0200, Bob Beck wrote:
> * Theo de Raadt <dera...@cvs.openbsd.org> [2009-08-09 03:56]:
> > > On 2009/08/08 15:25, Tim van der Molen wrote:
> > > > If httpd is disabled, then syslogd doesn't have to create a socket for
> > > > it.
> > > 
> > > Other httpd's might be using this, I think it should stay.
> > 
> > Indeed, there is a bigger issue here.
> > 
> > If you start these services yourself by hand later, you will not have
> > the log sockets that you expect, resulting in various kinds of
> > failure.  Perhaps we should always request that those log sockets be
> > created, unconditionaly, just in case the admin decides he wants to
> > add those services later.  It is essentially free.

OK, that makes sense. How about this diff, then?

As an aside, why does rc check if /var/empty exists but doesn't do so
for /var/named and /var/www?

Regards,
Tim

Index: rc
===================================================================
RCS file: /cvs/src/etc/rc,v
retrieving revision 1.331
diff -u -r1.331 rc
--- rc  7 Aug 2009 22:27:47 -0000       1.331
+++ rc  9 Aug 2009 19:56:48 -0000
@@ -331,15 +331,8 @@
 dmesg >/var/run/dmesg.boot
 
 echo 'starting system logger'
-rm -f /dev/log
-if [ X"${httpd_flags}" != X"-u" ]; then
-       rm -f /var/www/dev/log
-       syslogd_flags="${syslogd_flags} -a /var/www/dev/log"
-fi
-if [ X"${named_flags}" != X"NO" ]; then
-       rm -f /var/named/dev/log
-       syslogd_flags="${syslogd_flags} -a /var/named/dev/log"
-fi
+rm -f /dev/log /var/named/dev/log /var/www/dev/log
+syslogd_flags="${syslogd_flags} -a /var/named/dev/log -a /var/www/dev/log"
 if [ -d /var/empty ]; then
        rm -f /var/empty/dev/log
        mkdir -p -m 0555 /var/empty/dev

Reply via email to