Guy Harris wrote:

Loris Degioanni wrote:

Some genius had the idea of adding a new file (print-slow.c) to the repository few hours before the x.9.2 release, without at least trying to recompile on all the platforms. Result: tcpdump 3.9.2 doesn't compile under Windows (even if it used to compile the night before the release).


There needs to be a developer's document of some sort that says "if you add a source file to tcpdump, you need to add it to:

    Makefile.in;

    FILES;

    INSTALL (well, that's not a *requirement*, but it's a good idea);

    win32/prj/GNUmakefile;

    win32/prj/WinDump.dsp;

Yes, in a genera way, we should a a pre-release building (and possibly testing?) procedure, carried on by one person (or a limited group of people) after the CVS has been locked.

and give examples of what's added to all those files.

Ethereal avoids problems such as these by not doing Win32 projects - builds are done with command-line "nmake" - and having both the nmake files and the Makefile.am files include Makefile.common files, so that there's only *one* list of files.

The approach we've always used for our tools (WinDump, WinPcap, now ntar) is two separate "makefiles" for Unix and Windows. This is more complex for the developers of the tools, but makes life simple for the users that download your source code. (Maybe it's lack of experience, but I've always needed at least some hours to set-up the Ethereal build envronment, while with WinDump it's a matter of seconds). Moreover, Windows developers normally like to use the MS integrated IDEs better than gcc/gdb/make. However, if you think another approach is better, there's of course no problem to switch to another solution.

Note also that WinDump and WinPcap have a cygnus makefile *too*, wich is not integrated with the main autoconf/make, and which we (WinPcap team) manitain. It would probably be a good idea to merge it into the main build system.

Loris


It also catches at least some other problems by using Buildbot:

    http://buildbot.sourceforge.net/

so at least some build problems get caught (if tcpdump were to do the same, the builds should be done from tarballs generated by "make tar", so that it catches files not added to FILES).
-
This is the tcpdump-workers list.
Visit https://lists.sandelman.ca/ to unsubscribe.

-
This is the tcpdump-workers list.
Visit https://lists.sandelman.ca/ to unsubscribe.

Reply via email to