On Sun, Jan 30, 2005 at 05:39:22PM -0800, Guy Harris wrote: > Guy Harris wrote: > >Hannes Gredler wrote: > > > >>i have checked in support for the new DLT_PPP_WITH_DIRECTION (166) and > >> LINKTYPE_PPP_WITH_DIRECTION (166) > > > >Hmm. From what Karsten says, it's a bit special, with the 0xff in the > >HDLC-like header replaced by a direction flag, rather than with a > >direction flag added in front of the HDLC-like header. Given that, I > >might be inclined to pick a different name for it. > > I've renamed it to DLT_LINUX_PPP_WITH_DIRECTION.
Hmm, I think it should be become a general feature, since filtering for inbound/outbound for pppd based connections is a common problem and not Linux specific. Since this need some support of the OS kernel it is only available under Linux and so far I understand the code in if_ppp.c in FreeBSD too. Note FreeBSD still use DLT_PPP yet and so run into the same problems with libpcap 0.8X (it cannot filter OUT/IN bound) with DLT_PPP of libpcap 0.8X versions, in libpcap 0.7X it was possible, because the in/outbound flag was implemented in DLT_PPP in the same way as now DLT_PPP_WITH_DIRECTION does. So I would keep DLT_PPP_WITH_DIRECTION and not rename it to DLT_LINUX_PPP_WITH_DIRECTION, since it is a common solution, not a Linux specific one. -- Karsten Keil SuSE Labs ISDN development - This is the tcpdump-workers list. Visit https://lists.sandelman.ca/ to unsubscribe.
