ma1 pushed to branch tor-browser-140.2.0esr-15.0-1 at The Tor Project / 
Applications / Tor Browser


Commits:
c83c49f7 by hackademix at 2025-08-27T18:53:07+02:00
BB 44125: Do not offer to save signatures by default in Private Browsing Mode

- - - - -


2 changed files:

- toolkit/components/pdfjs/content/PdfjsParent.sys.mjs
- toolkit/components/pdfjs/content/web/viewer.mjs


Changes:

=====================================
toolkit/components/pdfjs/content/PdfjsParent.sys.mjs
=====================================
@@ -152,6 +152,8 @@ export class PdfjsParent extends JSWindowActorParent {
         return this.#getSignatures(data);
       case "delete":
         return this.#deleteSignature(data);
+      case "isVolatile":
+        return lazy.PrivateBrowsingUtils.isBrowserPrivate(this.browser);
       default:
         return null;
     }


=====================================
toolkit/components/pdfjs/content/web/viewer.mjs
=====================================
@@ -2009,6 +2009,9 @@ class SignatureStorage {
   async size() {
     return (await this.getAll()).size;
   }
+  async isVolatile() {
+    return await this.#handleSignature({action: "isVolatile"});
+  }
   async create(data) {
     if (await this.isFull()) {
       return null;
@@ -12736,7 +12739,8 @@ class SignatureManager {
     this.#uiManager.removeEditListeners();
     const isStorageFull = await this.#signatureStorage.isFull();
     this.#saveContainer.classList.toggle("fullStorage", isStorageFull);
-    this.#saveCheckbox.checked = !isStorageFull;
+    const isVolatile = await this.#signatureStorage.isVolatile();
+    this.#saveCheckbox.checked = !(isStorageFull || isVolatile);
     await this.#overlayManager.open(this.#dialog);
     const tabType = this.#tabButtons.get("type");
     tabType.focus();



View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c83c49f7197feb38fa9912b7c8fec6fd346db7a8

-- 
View it on GitLab: 
https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c83c49f7197feb38fa9912b7c8fec6fd346db7a8
You're receiving this email because of your account on gitlab.torproject.org.


_______________________________________________
tbb-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to