Hi
On Fri, Sep 12, 2014 at 3:49 PM, <[email protected]> wrote:
> From: Philippe De Swert <[email protected]>
>
> The line under the last switch statement *loaded_policy = true;
> would never be executed. As all switch cases return 0. Thus the
> policy would never be marked as loaded.
>
> Found with Coverity. Fixes: CID#1237785
Looks good, applied.
Thanks
David
> ---
> src/core/smack-setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/core/smack-setup.c b/src/core/smack-setup.c
> index 5f6dabf..5d8a26c 100644
> --- a/src/core/smack-setup.c
> +++ b/src/core/smack-setup.c
> @@ -158,7 +158,7 @@ int smack_setup(bool *loaded_policy) {
> return 0;
> case 0:
> log_info("Successfully loaded Smack/CIPSO policies.");
> - return 0;
> + break;
> default:
> log_warning("Failed to load Smack/CIPSO access rules: %s,
> ignoring.",
> strerror(abs(r)));
> --
> 1.8.3.2
>
> _______________________________________________
> systemd-devel mailing list
> [email protected]
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel
_______________________________________________
systemd-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
