On Thu, 26.06.14 10:37, Eugene Yakubovich ([email protected]) wrote: > > > On Wed, 25.06.14 18:03, Eugene Yakubovich ([email protected]) wrote: > > > > The patch is line-broken.... > I resent it last night with [PATCH resent] in the subject. Is that one > also line broken? It was resent with git send-email so should be ok.
Yeah, that one looks good. Didn't notice it earlier. Sorry for the confusion. > > Just one quick question without looking into much detail into the patch: > > why add a new UseRoutes= switch for this? Why shouldn't this be done > > always when DHCP is enabled? > > > > Definitely something that I would like feedback on. I mostly followed > the lead for UseMTU switch -- that is use a switch for less common > DHCP options. Maybe it's better to have that switch default to true > (vs false as now) but I do think having an ability to opt out of DHCP > server specified routes is a good idea. Since the user can specify > options in [Routes] section, he might be doing something custom and > not want routes specified by the network admin (via DHCP). I am tempted to say that we should try to apply as much information from DHCP as we can by default, but make sure it doesn't become a security problem. i.e. we should probably use metrics or so so that manual routes always win, or routes to other interfaces. I can see that it might make sense to turn this off, though I would probably not have bothered if I had done the patch myself. So, yeah, opt-out sounds good to me. Lennart -- Lennart Poettering, Red Hat _______________________________________________ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel
