On Fri, Mar 28, 2014 at 7:38 PM, Hristo Venev <[email protected]> wrote: > On Fri, 2014-03-28 at 19:06 +0100, Kay Sievers wrote: >> On Fri, Mar 28, 2014 at 6:38 PM, Hristo Venev <[email protected]> wrote: >> > The first patch moves the user generator directories to XDG_RUNTIME_DIR. >> > This >> > way the path for the generator directories is always under the manager's >> > runtime prefix. Consistency and code size. >> > >> > The second patch moves the transient user units to XDG_RUNTIME_DIR. This >> > way >> > they are deleted on reboot just like the system transient units and do not >> > take >> > space in XDG_CONFIG_HOME. >> > >> > The third patch lets transient units set EnvironmentFiles. It can be used >> > in >> > systemd-run like this: systemd-run -p EnvirontmentFiles="fileA fileB fileC" >> > Drop-in files for this are not yet implemented. >> >> Please include any *why*, along with the *what* in the commit log itself. >> >> The commit subject really does not help to explain why something is >> changed, and that is what matters, in the end; the patch itself >> usually explains pretty well what is done, but not why.
> First patch: Consistency and code size. Predictability of the location > of the generator directories => easier debugging. > Second patch: I DO NOT WANT TRANSIENT UNIT LEFTOVERS IN MY > XDG_CONFIG_HOME! > Third patch: Isn't it obvious that it's a (very small) new feature? I meant, the *why* you added here, should be in the *commits* themselves, not in the *announce* of them. We want the *why* in the git history, but the announce mail will not be there. Kay _______________________________________________ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel
