On Fri, 14.03.14 23:53, Daniel Buch ([email protected]) wrote: > + struct sockaddr_in sa = { > + .sin_family = AF_INET, > + .sin_addr.s_addr = inet_addr(argc >= 3 ? argv[2] : > "193.99.144.71"), > + .sin_port = htons(80) > + };
I'd prefer not to invoke functions within variable declarations. htons() is OK, since glibc actually defines this as a macro that is resolved at compile time, but please do inet_addr() in later code. Otherwise looks great! Lennart -- Lennart Poettering, Red Hat _______________________________________________ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel
