On Sat, 2013-12-28 at 15:17 +0100, Lennart Poettering wrote: > > Hmm, did you run into an actual problem with this? > > match_free() only undoes the registration if m->client is actually > set. Which it isn't in this case, since we actually set m->client after > the hashmap_replace() succeeded. Actually, we use whether m->client is > set or not as indication whether we have to remove the match from the > hashmap and the list that is appended to each entry. > > To me it appears the currently code is quite correct, or am I missing > anything? > > Lennart >
I might have gotten this one wrong, I actually found it while looking for another one (3/4) which caused me a coredump because of the last assert in LIST_REMOVE Marc-Antoine _______________________________________________ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel
