On Tue, Dec 10, 2013 at 01:44:02PM +0100, Thomas H.P. Andersen wrote: > >> Makefile.am: > >> Moved some -D's from CFLAGS to CPPFLAGS. I also simplified them a > >> bit and got rid of a left over DBUS_CFLAGS. > > I think that this breaks compilation if the directory has > > spaces in the name. Not a big deal, but as a matter of principle > > we should do it right. I think that > > > > -DTEST_DIR='"$(top_srcdir)/test"' should work. > I do not know how to validate this. Maybe we should just move it from > CFLAGS to CPPFLAGS without changing it and leave that for a separate > patch? I'm pretty sure it's fine as proposed, but to test it: run make V=1, and copy the gcc invocation line, replace '-c -o ...' with -E, and look at the output. I think it doesn't make sense to do a separate patch to touch all the same lines.
Zbyszek _______________________________________________ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel
