On Fri, Jul 12, 2013 at 3:40 PM, Lennart Poettering <[email protected]> wrote: > On Fri, 12.07.13 20:33, Tom Gundersen ([email protected]) wrote: > >> >> On Fri, Jul 12, 2013 at 8:16 PM, Lennart Poettering >> <[email protected]> wrote: >> > Oh, humm, does the unit file really belong in systemd? Sounds like >> > something that should be in kmod, no? >> >> I don't have a strong opinion about where the unit should live. As far >> as I remember Lucas requested I put it in systemd, but I forgot now >> what his rationale was. Lucas? > > Well, Zbigniew made a good point, and there are other cases where we > ship a unit file for something that is maintained outside of systemd, so > maybe leave it as is...
Indeed, what Zbigniew said. > >> > And I don't really like that we need to invoke /usr/bin/mkdir first... I'd >> > prefer if kmod could do that on its own when creating the file? >> >> Sure, could do. Just out of interest, why do you prefer it that way? > > Forking sucks... I like the simplicity of having "one-liners" in unit > files, if you get what i mean... And it sounds so wrong having to invoke > mkdir for a dir in /run exlicitly when prepping for a tool that, well, > is mostly concerned with creating dirs in /run. I'd rather prefer to > hide that fact... ;-) I agree. We are adding it to kmod so version 15 will create the parent dirs and this ExecStartPre will no longer be necessary. Lucas De Marchi _______________________________________________ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel
