On Tue, 09.07.13 21:15, Jan Janssen ([email protected]) wrote:

> +        if (*key_file) {
> +                r = read_one_line_file(*key_file, &passphrase);
> +                if (r < 0) {
> +                        log_error("Failed to read key file: %s", 
> strerror(-r));
> +                        *key_file = NULL;
> +                        return -EAGAIN;

I can't say I like functions that change the parameters when they fail,
any chance we can fix that?

otherwise looks good.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.
_______________________________________________
systemd-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Reply via email to