Hello Dongjun Jang,
장동준 [2013-06-28 7:09 +0000]:
> Please review the attached patch for the samsung series 3 Fn+F* keys(keymap
> and forced release events).
> This patch is for 300E5EV/300E4EV/270E5EV/270E4EV which is samsung series3
> models.
This looks good by and large, but I wonder about the product matching:
+ENV{DMI_VENDOR}=="[sS][aA][mM][sS][uU][nN][gG]*",
ATTR{[dmi/id]product_name}=="300E5EV/300E4EV/270E5EV/270E4EV",
RUN+="keyboard-force-release.sh $devpath samsung-series-3"
This is called "series-3", but only applies to very specific models.
Will other, similar, models use the same keymap? I. e. would it be
appropriate to generalize this to something like
+ENV{DMI_VENDOR}=="[sS][aA][mM][sS][uU][nN][gG]*",
ATTR{[dmi/id]product_name}=="300*|270E*", RUN+="keyboard-force-release.sh
$devpath samsung-series-3"
(Please note that alternatives are specified with |, not with / as in
your patch). This rule would apply to any model that starts with "300"
or "270E". Perhaps it can be generalized even further.
Thanks,
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
_______________________________________________
systemd-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
