On 04/25/2013 07:59 PM, Mantas Mikulėnas wrote:
> - Consistent use of $VAR vs ${VAR}
> - Consistent use of && vs 'if'
> - Add error checking to some places
> - Consistent error messages ("Can't" vs "Cannot", etc.)
> - Function declarations at the top
> - Miscellaneous adjustments
> ---
> src/kernel-install/kernel-install | 137
> +++++++++++++++++++++-----------------
> 1 file changed, 75 insertions(+), 62 deletions(-)
>
looks good from a first quick review
_______________________________________________
systemd-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
