On Wed, Mar 27, 2013 at 04:58:31PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Mar 27, 2013 at 04:50:48PM +0100, Lennart Poettering wrote: > > On Wed, 27.03.13 15:16, Vaclav Pavlin ([email protected]) wrote: > > > > > From: Václav Pavlín <[email protected]> > > > > > > --- > > > src/udev/udevd.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/src/udev/udevd.c b/src/udev/udevd.c > > > index b30bedf..379168d 100644 > > > --- a/src/udev/udevd.c > > > +++ b/src/udev/udevd.c > > > @@ -819,7 +819,9 @@ static void static_dev_create_from_modules(struct > > > udev *udev) > > > char buf[4096]; > > > FILE *f; > > > > > > - uname(&kernel); > > > + if (uname(&kernel) < 0) > > > + return; > > > + > > > > I wouldn't mind enclosing this in assert_se(), since this specific > > system call cannot realistically fail. > Hi, > assert might not be nice, because of random selinux denials... Wouldn't it be > better to continue if possible? Hi, I've now pushed the a version with a normal test + log, instead of assert. This is a syscall after all.
Zbyszek _______________________________________________ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel
