On Sat, Mar 23, 2013 at 03:11:41AM +0100, Lennart Poettering wrote: > On Wed, 13.03.13 10:27, Umut Tezduyar ([email protected]) wrote: > > > No need to try to stop systemd-sysctl on shutdown as > > this service doesn't have ExecStop= anyways. > > It's kinda nice if all services are gone from the service list when we > shut down, and doing this costs pretty much nothing. > > Also, the patch is incomplete, as shutdown.target is still listed in > Before=. > > Anyway, I fail to see the reason why we would want to apply this patch... Hi, I applied the patch, because it simplifies things by a tiny bit, removing one explicit relationship. But please do revert if what was there before was better.
Zbyszek > > > --- > > units/systemd-sysctl.service.in | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --git a/units/systemd-sysctl.service.in > > b/units/systemd-sysctl.service.in > > index 45e1ceb..d914553 100644 > > --- a/units/systemd-sysctl.service.in > > +++ b/units/systemd-sysctl.service.in > > @@ -9,7 +9,6 @@ > > Description=Apply Kernel Variables > > Documentation=man:systemd-sysctl.service(8) man:sysctl.d(5) > > DefaultDependencies=no > > -Conflicts=shutdown.target > > After=systemd-readahead-collect.service systemd-readahead-replay.service > > Before=sysinit.target shutdown.target > > ConditionPathIsReadWrite=/proc/sys/ _______________________________________________ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel
