On Friday, 25. January 2013 16:58:48 Lennart Poettering wrote:
> > - if (fstat(fd, &st) < 0)
> > + if (fstat(fd, &st) < 0) {
> > + close_nointr_nofail(fd);
>
> I figure cppcheck needs to learn about _cleanup_close_... We use gcc's
> cleanup attribute logic to close this file. In fact we make use of that
> quite heavily now for memory and other kind of resourec allocation....
Thanks for the hint, I'll take care of that. I wasn't even aware about the
_cleanup_close stuff so my eyes skipped it while reading ;)
Thomas
_______________________________________________
systemd-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/systemd-devel