Hi, As we've discussed the semantics of (specifically) nfs mounts with the nofail option, it seems that latest libmount+nfs-utils do not handle the nofail option between them which causes mount failures if it's specified in the fstab.
The following patch to util-linux tells libmount to strip off the nofail option before handing it to the mount helper, but perhaps this is too general and some mount helpers for different filesystems need to nofail option to be passed through? An alternative is simply to tech nfs-utils about the option. Question is: Which is the correct approach? Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/
>From 154b351ff495bd8175aa091ce489e369042b5e70 Mon Sep 17 00:00:00 2001 From: Colin Guthrie <[email protected]> Date: Sun, 30 Sep 2012 13:49:04 +0100 Subject: [PATCH] libmount: Mark 'nofail' as a userspace option. At least mount.nfs does not understand this option and it causes failures. An alternative option is to teach nfs-utils the 'nofail' option, but this option seems like one to be handled higher up the stack. --- libmount/src/optmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libmount/src/optmap.c b/libmount/src/optmap.c index 68217ce..60a5421 100644 --- a/libmount/src/optmap.c +++ b/libmount/src/optmap.c @@ -151,7 +151,7 @@ static const struct libmnt_optmap userspace_opts_map[] = { "sizelimit=", MNT_MS_SIZELIMIT, MNT_NOHLPS | MNT_NOMTAB }, /* loop device size limit */ { "encryption=", MNT_MS_ENCRYPTION, MNT_NOHLPS | MNT_NOMTAB }, /* loop device encryption */ - { "nofail", MNT_MS_NOFAIL, MNT_NOMTAB }, /* Do not fail if ENOENT on dev */ + { "nofail", MNT_MS_NOFAIL, MNT_NOHLPS | MNT_NOMTAB }, /* Do not fail if ENOENT on dev */ { "uhelper=", MNT_MS_UHELPER }, /* /sbin/umount.<helper> */ -- 1.7.12.1
_______________________________________________ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel
