Hi, while building systemd on ppc, I spotted a warning in src/journal/cat.c where a char could be used to retrieve a error code, except on ppc, char are unsigned. After discussing the issue with Kay on irc, it was decided to use int8_t instead.
Attached patch for this fix. -- Frederic Crozat <[email protected]> SUSE
>From dd1e3d5a396284d1afdb2828991a543eb80c8040 Mon Sep 17 00:00:00 2001 From: Frederic Crozat <[email protected]> Date: Thu, 22 Mar 2012 09:39:54 +0100 Subject: [PATCH] journal: char is unsigned on ppc, use int8_t instead. --- src/journal/cat.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/journal/cat.c b/src/journal/cat.c index 31d76f3..8a51fb7 100644 --- a/src/journal/cat.c +++ b/src/journal/cat.c @@ -33,7 +33,7 @@ #include "build.h" static char *arg_identifier = NULL; -static char arg_priority = LOG_INFO; +static int8_t arg_priority = LOG_INFO; static bool arg_level_prefix = true; static int help(void) { -- 1.7.7
_______________________________________________ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel
