On Thu, 16 Feb 2012, Hiroki Sato wrote:
Eitan Adler <[email protected]> wrote
in <[email protected]>:
ea> Author: eadler
ea> Date: Thu Feb 16 05:17:06 2012
ea> New Revision: 231817
ea> URL: http://svn.freebsd.org/changeset/base/231817
ea>
ea> Log:
ea> Fix warning when compiling with gcc46
IMHO it is not a good idea to remove unused code partially like this
or unused code in one from another project if you just want to
suppress a compiler warning. It may suppress the warning, but
remaining bits in comments and/or conditional parts where the
compiler does not complain make developers confused. I think it is
more harmful than the warning.
This is another example of the phenomenon that small bikesheds are the
hardest to paint :-). It is surprisingly difficult to make many small
harmless-looking changes correctly without knowing their full context,
since just determining their full context may take a day or three.
Each.
Bruce
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "[email protected]"
