> On Nov 7, 2020, at 11:28 AM, Dirk Hohndel via subsurface
> <[email protected]> wrote:
>
>> Problems common to all platforms:
>> - in the dive computer "device names" tab, all three columns
>> (Mode/DevID/Nickname) are too narrow by default, all columns need to be
>> widened to read the headers and table data.
>> - Filter set names can be saved with embedded HTML tags, and when reloaded
>> the HTML tags are rendered directly as HTML in the "Current set" field. I
>> dont know if it could be exploited to do XSS by loading a malicious dive
>> log. I couldnt find any other user-inputted text that behaves like this,
>> only the displayed filter set save names.
>>
>> - Filter set save names are mangled if you use the ampersand character. "& "
>> (with trailing space) gets rendered as "_". Seems reasonable to have a
>> filter set named "Alice & Bob" for your dives with both Alice and Bob.
>> Workaround is to name the filter set "Alice && Bob".
>
> I believe that Berthold has responded to all three of these and fixed or
> improved at least the first two. With latest master (not looking at
> Berthold's latest branch, yet), I can reproduce that the drop down doesn't
> include the '&' - everything else seems to render it correctly
OK, I think that's fixed in master now.
>> - Perdix BLE downloads worked OK with the builtin MBP bluetooth, BUT in the
>> bluetooth "Choose Bluetooth download mode" popup, the panel which shows the
>> discovered BT devices show their names/uuids with white text on white
>> background :-(. Clicking on a device name makes the text show up, but its
>> not friendly to a new user who doesnt know how it is supposed to look.
>
> You are saying that 'white on white' is not your preferred color choice?
> That's odd :-)
> Ok, I'll fix that. Thanks for catching it. As I've said many times before. I
> never use dark mode.
Also fixed in master.
Yay :-)
/D
_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
