On 18 November 2017 at 17:51, Willem Ferguson <[email protected]> wrote: > On 18/11/2017 00:01, Lubomir I. Ivanov wrote: > > @neolit123 requested changes on this pull request. > > @willemferguson > > hi, Willem. i've made a more detailed review for this commit. it needs work, > before we can accept it in. so, please, comment on my comments if you'd > like. > > most importantly, please do not change the bundled "One Dive.htmlfile and > instead commit a new one - e.g.One Dive .html`. > > you might have to learn how to git rebase. > > Lubomir, > > I think I will just send a patch that does not include the automatic text > sizing in the notes text field. This will remove the hacked code. I will > work with that separately and if I can get a more elegant solution submit > that as a separate PR.
we can technically re-use the already existing PR for this, but if you'd prefer i can close it? > > I agree that we should keep the old version. > > Does this sound acceptable? > keeping the old version sounds good. lubomir -- _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
