> On Jul 14, 2017, at 6:30 AM, Stefan Fuchs <[email protected]> wrote:
> 
>>> 
>> 
>> I'm running with the current master of the subsurface marble version. 
>> If you browse 
>> https://github.com/Subsurface-divelog/marble/tree/Subsurface-branch/src/lib/marble
>>  
>> <https://github.com/Subsurface-divelog/marble/tree/Subsurface-branch/src/lib/marble>
>>  its gone. 
> I faced the same issue some days ago when I tried to generate a new Windows 
> MXE build of Subsurface and also the linux build fails. So it's nothing 
> distro related (I'm on Xubuntu 16.04).
> 
> I think the issue appeared after merging Tomaz "fixMarble" branch which had a 
> huge update into Subsurface-branch of marble.
> 
> The commit where marble_export.h is deleted is this one:
> https://github.com/Subsurface-divelog/marble/commit/b5dc725832839986048f64ced12c6491cdb954a1
>  
> <https://github.com/Subsurface-divelog/marble/commit/b5dc725832839986048f64ced12c6491cdb954a1>
> 
> And I guess it's done intentionally. But I up to now didn't figure out how 
> this "generate_export_header" thing should work or why it's not working for 
> us.
> 
> 
> BTW: Tomaz, Dirk:  Does it even make sense to merge Tomaz marble update but 
> not merge this PR:
> https://github.com/Subsurface-divelog/subsurface/pull/468 
> <https://github.com/Subsurface-divelog/subsurface/pull/468>
> And does it even make sense to change anything around marble if you plan to 
> move to QT Location? ;-)
> 

See my other comment - I should have reverted Tomaz' changes to Marble. But he 
told
me that he'd fix it right away and then I was focused on Android (where we 
don't use
Marble) and it slipped my mind.

Either we get Marble fixed today, or I'll revert the changes.

/D

_______________________________________________
subsurface mailing list
[email protected]
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to