On Wed, Feb 22, 2017 at 12:02:28PM +0100, Robert Helling wrote: > > > On 22.02.2017, at 11:03, Dirk Hohndel <[email protected]> wrote: > > > > Yeah OOPS, that description goes into the XML file / git storage. So we > > now have a localized string that has "meaning". Because of that we can't > > simply say "oh, we are merging two dives, they have the same cylinder, but > > in one of the two dives we have a 'better' description" (let's say one > > gets you the correct "AL80", the other one has the same volume / working > > pressure, but description "unknown”). > > In principle you could compare to the translation of “unknown” as well… > But this is ugly and might cause strange behavior when people change their > localization in the middle. > > > > > But because I foolishly decided to translate that string, we no longer can > > do that... > > > > Is this worth fixing? I.e., store "unknown" in this case as literal and > > instead translate "unknown" when it is encountered in the UI as tank > > description? I think that's the right thing to do, but I figured it was > > worth asking for feedback. > > > I guess that is the way to go. And make sure (at least for a while) that when > parsing such a file retranslate the translated version of unknown back to > unknown so we git rid of these in old logs.
That's the ugly part that I worry about... OK, I'll add a couple commits to take care of this. /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
