Actually, I found where sync() is used. In the tests. So NAK from here /D
> On Jan 6, 2017, at 11:53 PM, Tomaz Canabrava <[email protected]> wrote: > > Ack > > They look same > > On Sat, 7 Jan 2017 at 04:25, Dirk Hohndel <[email protected] > <mailto:[email protected]>> wrote: > Tomaz, > > > > this looks good to me. Can I get an ACK for both patches from you? > > > > /D > > > > > On Jan 6, 2017, at 2:10 AM, Rick Walsh <[email protected] > > <mailto:[email protected]>> wrote: > > > > > > It was never called > > > > > > Signed-off-by: Rick Walsh <[email protected] > > <mailto:[email protected]>> > > > --- > > > > > > As pointed out by Robert > > > > > > core/subsurface-qt/SettingsObjectWrapper.cpp | 29 > > ---------------------------- > > > core/subsurface-qt/SettingsObjectWrapper.h | 1 - > > > 2 files changed, 30 deletions(-) > > > > > > diff --git a/core/subsurface-qt/SettingsObjectWrapper.cpp > > b/core/subsurface-qt/SettingsObjectWrapper.cpp > > > index 34fe3dd..19fcaaa 100644 > > > --- a/core/subsurface-qt/SettingsObjectWrapper.cpp > > > +++ b/core/subsurface-qt/SettingsObjectWrapper.cpp > > > @@ -2315,35 +2315,6 @@ void SettingsObjectWrapper::load() > > > s.endGroup(); > > > } > > > > > > -void SettingsObjectWrapper::sync() > > > -{ > > > - QSettings s; > > > - s.beginGroup("Planner"); > > > - s.setValue("last_stop", prefs.last_stop); > > > - s.setValue("verbatim_plan", prefs.verbatim_plan); > > > - s.setValue("display_duration", prefs.display_duration); > > > - s.setValue("display_runtime", prefs.display_runtime); > > > - s.setValue("display_transitions", prefs.display_transitions); > > > - s.setValue("safetystop", prefs.safetystop); > > > - s.setValue("reserve_gas", prefs.reserve_gas); > > > - s.setValue("ascrate75", prefs.ascrate75); > > > - s.setValue("ascrate50", prefs.ascrate50); > > > - s.setValue("ascratestops", prefs.ascratestops); > > > - s.setValue("ascratelast6m", prefs.ascratelast6m); > > > - s.setValue("descrate", prefs.descrate); > > > - s.setValue("bottompo2", prefs.bottompo2); > > > - s.setValue("decopo2", prefs.decopo2); > > > - s.setValue("bestmixend", prefs.bestmixend.mm > > <http://prefs.bestmixend.mm/>); > > > - s.setValue("doo2breaks", prefs.doo2breaks); > > > - s.setValue("drop_stone_mode", prefs.drop_stone_mode); > > > - s.setValue("switch_at_req_stop", prefs.switch_at_req_stop); > > > - s.setValue("min_switch_duration", prefs.min_switch_duration); > > > - s.setValue("bottomsac", prefs.bottomsac); > > > - s.setValue("decosac", prefs.decosac); > > > - s.setValue("deco_mode", int(prefs.deco_mode)); > > > - s.endGroup(); > > > -} > > > - > > > SettingsObjectWrapper* SettingsObjectWrapper::instance() > > > { > > > static SettingsObjectWrapper settings; > > > diff --git a/core/subsurface-qt/SettingsObjectWrapper.h > > b/core/subsurface-qt/SettingsObjectWrapper.h > > > index 7fdd104..67fc6ac 100644 > > > --- a/core/subsurface-qt/SettingsObjectWrapper.h > > > +++ b/core/subsurface-qt/SettingsObjectWrapper.h > > > @@ -715,7 +715,6 @@ public: > > > UpdateManagerSettings *update_manager_settings; > > > DiveComputerSettings *dive_computer_settings; > > > > > > - void sync(); > > > void load(); > > > private: > > > SettingsObjectWrapper(QObject *parent = NULL); > > > -- > > > 2.9.3 > > > > > > _______________________________________________ > > > subsurface mailing list > > > [email protected] <mailto:[email protected]> > > > http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface > > <http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface> > > >
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
