Willem, excellent!
> Am 19.11.2016 um 13:44 schrieb Willem Ferguson > <[email protected]>: > > Please, I need someone to check my coding carefully. I tested it > quite extensively and have not found any problems. Also, there may > be places where my code is inefficient. Looks good from my reading (haven’t tried to build it yet). Just a few comments: 1) You also change the resource name of the location icon. Is that intentional? 2) The picture counting code could probably be simplified a bit by using the FOR_EACH_PICTURE(dive) macro that iterates over the pictures of a dive. 3) Did you draw the icons yourself? If not, are the licenses compatible? Best Robert
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
