On Tue, Oct 18, 2016 at 3:36 AM, Edi Anderson <[email protected]> wrote: > Hi Dirk, > I am sorry for the problems in the previous patch. I correct the problems > and tested. I believe it is all right, if not, please let me know.
Just a quick comment from me. Patch number 2 introduces enableCheckboxes function in the header file, but the actual function implementation is elsewhere. You should try to group the patches so that Subsurface compiles at any given time, no matter where we jump in the git history. This is really useful when e.g. searching where a feature broke using git-bisect. Thus the implementation of enableCheckboxes should be in this same patch as the function prototype. You can do this using "git add -p desktop-widgets/plugins/facebook/facebookconnectwidget.cpp" when preparing the commit and choosing that specific chunk to be included along with the function prototype. HTH, miika _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
