I can see why it is important to have a well formatted code. Will pay more attention to it
Did you see the other one, about the trip headers? Il giorno Lun 5 Ott 2015 17:41 Dirk Hohndel <[email protected]> ha scritto: > On Mon, Oct 05, 2015 at 04:34:13PM +0100, Dirk Hohndel wrote: > > On Mon, Oct 05, 2015 at 05:19:35PM +0200, Giorgio Marzano wrote: > > > Dirk, > > > > > > this patch should fix the wrong values in the max depth field for > splitted > > > dives. > > > > It does - I already have a more complete patch in my tree but haven't had > > a chance to push that out, yet. Sorry about that. > > > > I'll take your patch and refactor mine on top of it :-) > > > > Patch looks good - maybe except for the two consecutive empty lines. > > The commit message - I prefer the commit title to be in present tense > (but > > don't always catch it when people write it in past tense). > > Oh, and the missing space on both sides of '=' - I'll push the commit > soon, please look at what ended up in master and compare to what you sent > > I know these are tiny nit-picks, but consistency is really important to > make the code easy to read and intuitive to understand. > > /D >
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
