On 18 June 2015 at 15:48, Dirk Hohndel <[email protected]> wrote: > On Thu, Jun 18, 2015 at 01:35:16PM +0200, Gehad Elrobey wrote: >> On Thu, Jun 18, 2015 at 9:52 AM, Lubomir I. Ivanov <[email protected]> >> wrote: >> >> > On 17 June 2015 at 19:51, Gehad Elrobey <[email protected]> wrote: >> > > Hello Lubomir, >> > > >> > > I have amended the commit I mentioned above, I also added the support to >> > > print on many page sizes with different print qualities (This still needs >> > > more testing), I have pushed all the commits to my branch. >> > > >> > >> > thanks, >> > your branch seems to be missing the patch to fix this: >> > >> > error: 'm__nstance' was not declared in this scope >> > Q_ASSERT_X(m__nstance == NULL, "WindowTitleUpdate", "WindowTitleUpdate >> > recreat >> > ed!"); >> > >> > [Patch] Re-fix silly typo (was Current git no compilee) >> > >> > lubomir >> > -- >> > >> >> rebased with current master and pushed. > > Good - Lubomir are you going to sign off on them again? >
hello, haven't reviewed yet. will do soon. lubomir -- _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
