On Mon, Jun 15, 2015 at 12:16:02PM +0200, Davide DB wrote: > My V2 xml file had these dives: > > <location gps='42.254134 11.091063'>Isola di Giannutri - Nasim > II</location> > <location gps='42.254134 11.091063'>Isola di Giannutri - Le macchine > del Nasim</location> > <location gps='42.254134 11.091063'>Isola di Giannutri - Le macchine > del Nasim</location> > <location gps='42.254134 11.091063'>Isola di Giannutri - Le macchine > del Nasim</location> > <location gps='42.254134 11.091063'>Isola di Giannutri - Le macchine > del Nasim</location> > > GPS data are the same because it's the same entry point but different > dives, hence same gps data but different location names. > > The import process translated the above dives into a V3 xml file with > a unique dive site: > > <site uuid='44e919b6' name='Isola di Giannutri - Nasim II' > gps='42.254134 11.091063' notes='additional name for site: Isola di > Giannutri - Le macchine del Nasim additional name for site: Isola di > Giannutri - Le macchine del Nasim additional name for site: Isola di > Giannutri - Le macchine del Nasim additional name for site: Isola di > Giannutri - Le macchine del Nasim'/> > > Moreover it renamed four dives like the first one it found in the file > and added the old renamed dive names into the dive site note. > > It seems a fair compromise for an automatic conversion. It should be > well documented in the user manual and IMHO the future import dialog > should mention this behaviour.
That's not what I think is the RIGHT behavior and I thought I fixed that. At first that's what I implemented then after the discussions here I came to the conclusion that we should ONLY turn multiple locations into the same dive site if they have the identical name - otherwise the user will experience the surprising "change of the dive name" that you describe. I'll need to check why my fix was insufficient. /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
