> On Apr 16, 2015, at 8:37 AM, Lubomir I. Ivanov <[email protected]> wrote: > > On 16 April 2015 at 17:29, Dirk Hohndel <[email protected]> wrote: >> On Thu, Apr 16, 2015 at 01:52:55PM +0300, Lubomir I. Ivanov wrote: >>> On 16 April 2015 at 01:29, Dirk Hohndel <[email protected]> wrote: >>>> Those of you building from source... if you haven't switched to cmake, >>>> yet, now would be a very good time. I'm planning to drop support for qmake >>>> fairly soon, so please give it a try and let me know if there are any >>>> issues. >>>> >>> >>> i was able to again hack my way trough the native win32 build. >>> it's tolerable, but the pkg-config issues have deepened. >>> >>> 1) >>> pkg_config_library(LIBGIT2 libgit2) >>> ^ this seems to require an extra argument for me (e.g. REQUIRED) >>> otherwise it fails. >> >> Oops, missed that one in commit 7596db28b5ad >> Fix pushed. >> > > for some reason i can't get it to enter this branch: > if(NOT ${PREFER_GIT_FROMSOURCE}) > -> pkg_config_library(LIBGIT2 libgit2 REQUIRED) > > i've tried setting the option to OFF in the .txt file or via the command line.
I struggle with testing cmake variables… it’s entirely unclear when we should test STREQ “”, when we should test DEFINED or when we can use them directly as binary value as indicate in the if clause that you quote there… /D _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
