I added more patches which will fix some memory leaks. Regarding the uemis-downloader.c source I am not sure if "iparam_buff" and "mbuf" variables should be freed too.
I saw that one of the elements of "param_buff" is used as a result for the "do_uemis_import" function, but I didn't saw where it is freed. Claudiu On Sun, Mar 22, 2015 at 1:48 PM, Claudiu Olteanu < [email protected]> wrote: > Hello, > > This patch fixes some memory leaks from datatrak implementation. > > Claudiu >
From 5668e8c78c3ee07b486473dbe5ea00772c3117c0 Mon Sep 17 00:00:00 2001 From: Claudiu Olteanu <[email protected]> Date: Sun, 22 Mar 2015 13:38:51 +0200 Subject: [PATCH 1/3] Resolve some memory leak on datatrak source The result of byte_to_bits should be freed by the caller. This patch frees the memory allocated by that function. Also there were some memory leaks in data_import and read_file_header functions when an error occured. Signed-off-by: Claudiu Olteanu <[email protected]> --- datatrak.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/datatrak.c b/datatrak.c index 573796c..3dbddb6 100644 --- a/datatrak.c +++ b/datatrak.c @@ -120,6 +120,8 @@ static struct sample *dtrak_profile(struct dive *dt_dive, FILE *archivo) } j = 0; } + free(byte); + // In commit 5f44fdd setpoint replaced po2, so although this is not necesarily CCR dive ... if (is_O2) sample->setpoint.mbar = calculate_depth_to_mbar(sample->depth.mm, dt_dive->surface_pressure, 0) * o2percent / 100; @@ -141,6 +143,7 @@ static dtrakheader read_file_header(FILE *archivo) fread(lector, 1, headerbytes, archivo); if (two_bytes_to_int(lector[0], lector[1]) != 0xA100) { puts("Error: the file does not appear to be a DATATRAK divelog"); + free(lector); return fileheader; } fileheader.header = (lector[0] << 8) + lector[1]; @@ -394,6 +397,8 @@ static struct dive dt_dive_parser(FILE *archivo, struct dive *dt_dive) if (byte[7] != 0) taglist_add_tag(&dt_dive->tag_list, strdup(QT_TRANSLATE_NOOP("gettextFromC", "salt water"))); + free(byte); + /* * Dive Type 2 - Bit table, use tags again */ @@ -408,6 +413,7 @@ static struct dive dt_dive_parser(FILE *archivo, struct dive *dt_dive) is_SCR = 1; dt_dive->dc.divemode = PSCR; } + free(byte); /* * Dive Activity 1 - Bit table, use tags again @@ -430,7 +436,7 @@ static struct dive dt_dive_parser(FILE *archivo, struct dive *dt_dive) taglist_add_tag(&dt_dive->tag_list, strdup(QT_TRANSLATE_NOOP("gettextFromC", "ice"))); if (byte[7] != 0) taglist_add_tag(&dt_dive->tag_list, strdup(QT_TRANSLATE_NOOP("gettextFromC", "search"))); - + free(byte); /* * Dive Activity 2 - Bit table, use tags again @@ -447,6 +453,7 @@ static struct dive dt_dive_parser(FILE *archivo, struct dive *dt_dive) taglist_add_tag(&dt_dive->tag_list, strdup(QT_TRANSLATE_NOOP("gettextFromC", "photo"))); if (byte[4] != 0) taglist_add_tag(&dt_dive->tag_list, strdup(QT_TRANSLATE_NOOP("gettextFromC", "other"))); + free(byte); /* * Other activities - String 1st byte = long @@ -653,6 +660,7 @@ void datatrak_import(const char *file, struct dive_table *table) if ((archivo = subsurface_fopen(file, "rb")) == NULL) { puts("Error: couldn't open the file"); + free(fileheader); return; } @@ -674,5 +682,5 @@ void datatrak_import(const char *file, struct dive_table *table) taglist_cleanup(&g_tag_list); fclose(archivo); sort_table(table); - free (fileheader); + free(fileheader); } -- 2.1.4
From 1664780fc864991c5ca870dc7c2f7a83b8d80da8 Mon Sep 17 00:00:00 2001 From: Claudiu Olteanu <[email protected]> Date: Sun, 22 Mar 2015 14:12:12 +0200 Subject: [PATCH 2/3] Fix memory leaks on Cochran file Signed-off-by: Claudiu Olteanu <[email protected]> --- cochran.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cochran.c b/cochran.c index 855ca7c..fe65ee2 100644 --- a/cochran.c +++ b/cochran.c @@ -233,6 +233,7 @@ static void cochran_parse_header(const unsigned char *decode, unsigned mod, break; default: printf ("Unknown log format v%c\n", buf[0x137]); + free(buf); exit(1); break; } -- 2.1.4
From 9032cd225a80b27716a3e40839740812deda7f58 Mon Sep 17 00:00:00 2001 From: Claudiu Olteanu <[email protected]> Date: Sun, 22 Mar 2015 17:23:02 +0200 Subject: [PATCH] Fix a memory leak in parser-xml This patch cleans the memory alocated for a cobalt location. Signed-off-by: Claudiu Olteanu <[email protected]> --- parse-xml.c | 1 + 1 file changed, 1 insertion(+) diff --git a/parse-xml.c b/parse-xml.c index a42f8c8..0abcfcb 100644 --- a/parse-xml.c +++ b/parse-xml.c @@ -2637,6 +2637,7 @@ extern int cobalt_location(void *handle, int columns, char **data, char **column free(location); location = NULL; cur_dive->dive_site_uuid = create_dive_site(tmp); + free(tmp); } else { location = strdup(data[0]); } -- 2.1.4
From 179362dbbf6fc40f890171f5a424bc19f8c854c1 Mon Sep 17 00:00:00 2001 From: Claudiu Olteanu <[email protected]> Date: Sun, 22 Mar 2015 17:36:15 +0200 Subject: [PATCH] Clean req.txt file path This patch cleans the path allocated for req.txt file. Signed-off-by: Claudiu Olteanu <[email protected]> --- uemis-downloader.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/uemis-downloader.c b/uemis-downloader.c index 3f22253..521cd7e 100644 --- a/uemis-downloader.c +++ b/uemis-downloader.c @@ -861,8 +861,10 @@ const char *do_uemis_import(device_data_t *data) if (dive_table.nr == 0) keep_number = true; uemis_info(translate("gettextFromC", "Initialise communication")); - if (!uemis_init(mountpath)) + if (!uemis_init(mountpath)) { + free(reqtxt_path); return translate("gettextFromC", "Uemis init failed"); + } if (!uemis_get_answer(mountpath, "getDeviceId", 0, 1, &result)) goto bail; deviceid = strdup(param_buff[0]); @@ -994,5 +996,6 @@ bail: result = param_buff[2]; } free(deviceid); + free(reqtxt_path); return result; } -- 2.1.4
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
