On Mon, Oct 28, 2013 at 06:57:06PM -0400, Trond Myklebust wrote: > Add the missing 'break' to ensure that we don't corrupt a legacy 'v0' type > message by appending the 'v1'.
ACK. Looks like that was a regression from bd4a3eb15bb42296e61d0fd16f2c7f8cc171b681 "RPCSEC_GSS: Clean up upcall message allocation" ? And it looks like it's overwriting, not appending, so the 'v0' case has probably been broken since then. --b. > > Cc: Bruce Fields <[email protected]> > Cc: [email protected] > Signed-off-by: Trond Myklebust <[email protected]> > --- > net/sunrpc/auth_gss/auth_gss.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c > index 084656671d6e..cc24323d3045 100644 > --- a/net/sunrpc/auth_gss/auth_gss.c > +++ b/net/sunrpc/auth_gss/auth_gss.c > @@ -482,6 +482,7 @@ gss_alloc_msg(struct gss_auth *gss_auth, > switch (vers) { > case 0: > gss_encode_v0_msg(gss_msg); > + break; > default: > gss_encode_v1_msg(gss_msg, service_name, gss_auth->target_name); > }; > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
