On Tue, 2012-10-16 at 10:31 -0400, Joseph Salisbury wrote: > On 09/09/2012 02:05 PM, Ben Hutchings wrote: > > On Thu, 2012-08-30 at 13:54 -0400, Joseph Salisbury wrote: > >> Hi, > >> > >> Please consider reverting commit > >> 3be324a94df0c3f032178d04549dbfbf6cccb09a in the next v3.2.y release. It > >> was included upstream as of v3.4-rc1. This commit introduced a > >> regression, described in the following bug: > >> http://bugs.launchpad.net/bugs/1028151 > >> > >> The original request to include this commit in v3.2.y can be found at: > >> http://www.mail-archive.com/[email protected]/msg10854.html > >> > >> The issue with commit 3be324a9, is that samsung-laptop started to load > >> on far more machine types, including some where brightness was already > >> being handled by ACPI video module. samsung-laptop and ACPI video are > >> now conflicting. > >> > >> The following commit can fix the regression: f34cd9ca ("samsung-laptop: > >> don't handle backlight if handled by acpi/video") instead of doing the > >> revert. > > Right, I clearly should have applied that first. > > > >> The was confirmed in the previously mentioned bug. However, to > >> cherry-pick commit f34cd9ca, it would need to be backported, and would > >> also require the two commits before to apply successfuly. The feeling > >> is all these changes may be too much for a stable release. > >> > >> Commits required as a pre-req to f34cd9ca: > >> a6df48943a408b493d1aa141791d614a529d484e > >> 5dea7a2094d5e60fe8f8ec4277d22d7ad6fa8c26 > > Yes, those are rather large! But I think it can be backported alone > > without enormous changes; see attached > > 'samsung-laptop-don-t-handle-backlight-if-handled-by-acpi-video.patch'. > > Then the dropped hunks of 3be324a9 should also be applied; see attached > > 'samsung-laptop-make-the-dmi-check-less-strict-part-2.patch'. Do these > > work? > > > > Ben. > > > > I finally received some feedback regarding these patches[0]. These > patches do resolved the bug. Thanks again, Ben. > > [0] > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1028151/comments/96
Thanks, I've added these to the queue for 3.2. Ben. -- Ben Hutchings Never attribute to conspiracy what can adequately be explained by stupidity.
signature.asc
Description: This is a digitally signed message part
