This is a note to let you know that I've just added the patch titled
fs/compat_ioctl.c: VIDEO_SET_SPU_PALETTE missing error check
to the 3.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
fs-compat_ioctl.c-video_set_spu_palette-missing-error-check.patch
and it can be found in the queue-3.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From 12176503366885edd542389eed3aaf94be163fdb Mon Sep 17 00:00:00 2001
From: Kees Cook <[email protected]>
Date: Thu, 25 Oct 2012 13:38:16 -0700
Subject: fs/compat_ioctl.c: VIDEO_SET_SPU_PALETTE missing error check
From: Kees Cook <[email protected]>
commit 12176503366885edd542389eed3aaf94be163fdb upstream.
The compat ioctl for VIDEO_SET_SPU_PALETTE was missing an error check
while converting ioctl arguments. This could lead to leaking kernel
stack contents into userspace.
Patch extracted from existing fix in grsecurity.
Signed-off-by: Kees Cook <[email protected]>
Cc: David Miller <[email protected]>
Cc: Brad Spengler <[email protected]>
Cc: PaX Team <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
fs/compat_ioctl.c | 2 ++
1 file changed, 2 insertions(+)
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -210,6 +210,8 @@ static int do_video_set_spu_palette(unsi
err = get_user(palp, &up->palette);
err |= get_user(length, &up->length);
+ if (err)
+ return -EFAULT;
up_native = compat_alloc_user_space(sizeof(struct video_spu_palette));
err = put_user(compat_ptr(palp), &up_native->palette);
Patches currently in stable-queue which might be from [email protected] are
queue-3.4/gen_init_cpio-avoid-stack-overflow-when-expanding.patch
queue-3.4/fs-compat_ioctl.c-video_set_spu_palette-missing-error-check.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
